This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-981] Add more codegen checking in BHJ & SHJ #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/native-sql-engine/issues Then could you also rename commit message and pull request title in the following format? See also: |
PHILO-HE
changed the title
zhouyuan
reviewed
Jun 28, 2022
| ColumnarExpressionConverter.replaceWithColumnarExpression(expr) | ||
| val columnarBuildKeyExpr = ColumnarExpressionConverter.replaceWithColumnarExpression(expr) | ||
| // Only do the check for the join having condition. | ||
| if (condition.isDefined) { |
There was a problem hiding this comment.
if there's no condition defined, this check will pass even the exprs does not support codegen, seems not enough?
There was a problem hiding this comment.
Yes, for no condition case, we still need to add the checking in supportColumnarCodegen of join operator. Will add it soon.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.